Fix CI (plus DX improvements) #2171
Closed
+54
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fcurella MyPy is failing, but it's running against the latest version as CI is governed by the state of the master branch. Having copied the process via my fork, you can see that these changes will pass CI once fixed: https://github.com/evenicoulddoit/faker/actions/runs/13195989491/job/36837366554?pr=4 |
evenicoulddoit
changed the title
|
Can you please undo all the DX changes, so we can review them in a separate PR? |
|
@fcurella yes and no. The crucial fix here I think is bumping MyPy. This isn't fixed on the master branch. This PR applies strict limits across the board, and uses them. I can produce a PR which just bumps MyPy but it would also fail for the reasons above? |
|
Done in 9c8b132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
extras_requireto enforce consistent versioning of development / ci / testing requirementsWhat was wrong
@overloaddecorator wasn't supported across the repo, due to the lack of support in the stub file generationHow this fixes it
Notes
Checklist
make lint